Amazon CodeGuruDetector Library Sign in to CodeGuru

CodeGuru

Detector Library

JavaScript detectors (78/78)

Improper access control Sensitive data stored unencrypted due to partial encryption Pseudorandom number generators OS command injection URL redirection to untrusted site Integer overflow Protection mechanism failure Non-literal regular expression Tainted input for Docker API Usage of an API that is not recommended XML external entity Server-side request forgery New function detected Stack trace exposure Timing attack SNS don't bind subscribe and publish Invoke super appropriately NoSQL injection Hardcoded credentials Insecure cookie Cross-site scripting Hardcoded IP address AWS credentials logged XPath injection Data loss in a batch request Path traversal Least privilege violation DNS prefetching Resource leak Insufficiently protected credentials File extension validation Insecure connection using unencrypted protocol Cross-site request forgery Typeof expression Set SNS Return Subscription ARN File and directory information exposure Missing Amazon S3 bucket owner condition Insecure hashing Numeric truncation error Client-side KMS reencryption AWS client not reused in a Lambda function LDAP injection Batch request with unchecked failures Cryptographic key generator Unauthenticated Amazon SNS unsubscribe requests might succeed Unverified hostname Origins-verified cross-origin communications Loose file permissions Unsanitized input is run as code Missing pagination Untrusted Amazon Machine Images Improper certificate validation Insecure CORS policy Deserialization of untrusted object Sensitive information leak Check failed records when using kinesis Weak obfuscation of web requests Catch and swallow exception Logging of sensitive information Limit request length String passed to `setInterval` or `setTimeout`Log injection Override of reserved variable names in a Lambda function Improper restriction of rendered UI layers or frames Insecure cryptography Insecure object attribute modification Session fixation Avoid nan in comparison Improper input validation Disabled HTML autoescape Use of a deprecated method Unvalidated expansion of archive files File injection Sendfile injection SQL injection Header injection Insecure temporary file or directory Inefficient polling of AWS resource

Sendfile injection High

User-provided inputs must be sanitized before being passed to res.sendFile. Otherwise an attacker could arbitrarily read files on the system through path traversal.

Detector ID

javascript/sendfile-injection@v1.0

Category

Common Weakness Enumeration (CWE)

Tags

# top25-cwes # owasp-top10

Noncompliant example

1var express = require("express")
2var path = require("path")
3var app = express()
4function sendfileInjectionNoncompliant() {
5    app.get('www.example.com', (req, res) => {
6        var fileName = req.params.file
7        // Noncompliant: tainted-data is passed into 'res.sendfile'.
8        res.sendFile(fileName)
9    })
10}

Compliant example

1var express = require("express")
2var path = require("path")
3var app = express()
4function sendfileInjectionCompliant() {
5    app.get('www.example.com', (req, res) => {
6        var fileName = "file.txt"
7        if (fileName !== req.params.file) {
8            // Compliant: validated fileName before passing into 'res.sendFile'.
9            res.sendFile(fileName)
10            console.log("Valid file name.")
11        } else {
12            throw new Error("Invalid file name.")
13        }
14    })
15}