CodeGuru
Detector Library
Java detectors (130/130)
Reflected cross site scriptingMandatory method not called after object creationProcess empty record list in Amazon KCLAWS object presence checkMissing timeout check on CountDownLatch.awaitUnspecified default valueDevice Permission Usage.Deserialization of untrusted objectPreserve thread interruption status ruleMissing check on the value returned by moveToFirst APIMissing timeout check on ExecutorService.awaitTerminationOverflow when deserializing relational database objectsCustom manual retries of AWS SDK callsMissing null check for cache response metadataInefficient usage of Transaction library from AWS LabsInsecure connection using unencrypted protocolInefficient additional authenticated data (AAD) authenticityUse of a deprecated methodError-prone AWS IAM policy creationUse of externally-controlled input to build connection stringInefficient Amazon S3 manual paginationMutually exclusive callAWS Lambda client not reusedMissing check on the result of createNewFileSensitive data stored unencrypted due to partial encryptionMissing statement to record cause of InvocationTargetExceptionMisconfigured ConcurrencyInefficient polling of AWS resourceUnexpected re-assignment of synchronized objectsXPath injectionAWS client not reused in a Lambda functionLong polling is not enabled in Amazon SQSInsecure temporary file or directoryHTTP response splittingInput and output values become out of syncServer-side request forgeryMissing Authorization for address idDo not catch and throw exceptionConcurrency deadlockNot recommended aws credentials classesPath traversalOverride of reserved variable names in a Lambda functionMissing byte array length of JSON parserUsage of an API that is not recommendedHardcoded credentialsInsecure JSON web token (JWT) parsingNot calling finalize causes skipped cleanup stepsUnchecked S3 object metadata content lengthUntrusted data in security decisionPermissive cors configuration ruleInsecure cookieResource leakXML External EntityBad parameters used with AWS API methodsMissing position check before getting substringLDAP injectionAvoid reset exception in Amazon S3Insecure hashingBackward compatibility breaks with error message parsingInefficient map entry iterationMissing S3 bucket owner conditionAWS DynamoDB getItem output is not null checkedInvalid public method parametersLog injectionSensitive information leakSynchronous publication of AWS Lambda metricsXML External Entity Document Builder FactoryImproper use of classes that aren't thread-safeIncorrect null check before setting a valueInsufficient use of name in Amazon SQS queueMissing check on the value returned by ResultSet.nextInsecure TLS versionUnsanitized input is run as codeUse an enum to specify an AWS RegionImproperly formatted string argumentsImproper service shutdownUnrestricted upload of dangerous file typeUntrusted AMI imagesInsecure SAML parser configurationCross-site request forgeryCase sensitive keys in S3 object user metadataStack trace not included in re-thrown exceptionRegion specification missing from AWS client initializationInsufficient number of PBEKeySpec iterationsURL redirection to untrusted siteUse of externally-controlled input to select classes or codeMissing encryption of sensitive data in storageIgnored output of DynamoDBMapper operationsNull pointer dereferenceCross-site scriptingUnauthenticated LDAP requestsUse of inefficient APIsLow maintainability with old Android featuresAtomicity violationMissing handling of specifically-thrown exceptionsWeak obfuscation of web requestClear text credentialsSession fixationCatching and not re-throwing or logging exceptionsMissing check when launching an Android activity with an implicit intentClient constructor deprecationInefficient use of stream sortingArithmetic overflow or underflowSimplifiable codeLoose file permissionsManual paginationIncorrect string equality operatorInefficient chain of AWS API callsOS command injectionInternationalizationCode cloneSQL injectionMissing check on method outputMissing paginationResources used by an Amazon S3 TransferManager are not releasedInsecure cryptographyMissing timezone of SimpleDateFormatLow maintainability with low class cohesionOversynchronizationInfinite loopBatch operations preferred over loopingObject Input Stream Insecure DeserializationWeak pseudorandom number generationInsecure CORS policyMissing handling of file deletion resultAmazon SQS message visibility changed without a status checkState machine execution ARN is not loggedClient-side KMS reencryptionUse Stream::anyMatch instead of Stream::findFirst or Stream::findAnyBatch request with unchecked failures
Medium
Showing all detectors for the Java language with medium severity.
Process empty record list in Amazon KCL
Setting
withCallProcessRecordsEvenForEmptyRecordList to TRUE during Kinesis Client Library (KCL) initialization will treat empty records differently.Device Permission Usage.
Do not use API that requests system permission directly. Please onboard mShop Permission Service first.
Missing check on the value returned by moveToFirst API
Missing check on the value returned by moveToFirst API can cause your application to crash.
Overflow when deserializing relational database objects
Deserializing objects from relational databases should allocate a 64-bit, not 32-bit, type for the auto-incremented identifier.
Custom manual retries of AWS SDK calls
Custom manual retries of calls to AWS SDK APIs are inefficient.
Use of a deprecated method
This code uses deprecated methods, which suggests that it has not been recently reviewed or maintained.
AWS Lambda client not reused
Reuse AWS clients in Lambda.
Sensitive data stored unencrypted due to partial encryption
Encryption that is dependent on conditional logic, such as an
if...then clause, might cause unencrypted sensitive data to be stored.AWS client not reused in a Lambda function
Recreating AWS clients in each Lambda function invocation is expensive.
Long polling is not enabled in Amazon SQS
Enable long polling for efficiency.
Insecure temporary file or directory
Insecure ways of creating temporary files and directories can lead to race conditions, privilege escalation, and other security vulnerabilities.
Concurrency deadlock
Improper use of locks in a multi-threaded program can lead to deadlock and cause the program to be unresponsive.
Missing byte array length of JSON parser
Specify the length of the input byte array when creating a
JSON parser to avoid a deserialization problem.Not calling finalize causes skipped cleanup steps
Always call
super.finalize explicitly.Resource leak
Allocated resources are not released properly.
Bad parameters used with AWS API methods
An outdated or bad parameters were detected in calls to some AWS API methods.
Missing position check before getting substring
Getting a substring outside the range of a string can cause an index-out-of-bounds exception.
Avoid reset exception in Amazon S3
Uploading objects to Amazon S3 by using streams (either through an AmazonS3 client or
TransferManager) might encounter network connectivity or timeout issues.Insecure hashing
Obsolete, broken, or weak hashing algorithms can lead to security vulnerabilities.
AWS DynamoDB getItem output is not null checked
Outputs of AWS DynamoDB's
GetItem method are not null checked.Invalid public method parameters
Public method parameters should be validated for nullness, unexpected values, and malicious values.
Improper use of classes that aren't thread-safe
Improper use of thread-unsafe classes in multi-threaded programs can cause the programs to be unstable.
Incorrect null check before setting a value
When a variable is assigned a value after checking if it's not
null (for example, x != null insead of x == null), it might be inadvertently overwritten.Untrusted AMI images
Improper filtering of Amazon Machine Images (AMIs) can result in loading an untrusted image, a potential security vulnerability.
Stack trace not included in re-thrown exception
When re-throwing an exception, make sure to include the stack trace.
Insufficient number of PBEKeySpec iterations
Using less than 1,000 PBEKeySpec iterations is insecure.
Null pointer dereference
Dereferencing a null pointer can lead to unexpected null pointer exceptions.
Use of inefficient APIs
Performance of this code can be enhanced by using alternative APIs.
Low maintainability with old Android features
Code uses older Android features.
Catching and not re-throwing or logging exceptions
It's not good practice to catch an exception and then re-throw or log it.
Inefficient use of stream sorting
Using
Stream::min or Stream::max is more efficient than sorting and getting the first element in a stream.Arithmetic overflow or underflow
Use numeric types that are large enough to hold the result of arithmetic operations.
Incorrect string equality operator
Use
equals(), not ==, when checking if two strings are equal.Inefficient chain of AWS API calls
The chain of API calls can be replaced with a single, more efficient API call.
Internationalization
Improper use of locals prevent internationalization.
Code clone
Similar code fragments were detected in the same file.
Missing pagination
Additional results are not checked for a paginated API call. This might produce inaccurate results.
Resources used by an Amazon S3 TransferManager are not released
Call
ShutdownNow when you use TransferManager to manage transfers to Amazon S3.Missing timezone of SimpleDateFormat
Using a
SimpleDateFormat object without setting its timezone can result in unexpected date and time.Low maintainability with low class cohesion
Classes with low class cohesion contain unrelated operations which make them difficult to understand and less likely to be used.
Infinite loop
Use loop control flow to ensure that loops are exited, even if exceptional behaviors are encountered.
Insecure CORS policy
Cross-Origin Resource Sharing policies that are too permissive may lead to security vulnerabilities.
Missing handling of file deletion result
Unhandled failures of deleting files can exhaust file handles.
Batch request with unchecked failures
Not checking which items have failed can lead to loss of data.