Amazon CodeGuruDetector Library Sign in to CodeGuru

CodeGuru

Detector Library

Java detectors (129/129)

Reflected cross site scripting Improper service shutdown Mandatory method not called after object creation Unrestricted upload of dangerous file type Process empty record list in Amazon KCL Untrusted AMI images AWS object presence check Insecure SAML parser configuration Cross-site request forgery Case sensitive keys in S3 object user metadata Missing timeout check on CountDownLatch.await Unspecified default value Device Permission Usage.Deserialization of untrusted object Stack trace not included in re-thrown exception Preserve thread interruption status rule Missing check on the value returned by moveToFirst API Missing timeout check on ExecutorService.awaitTermination Region specification missing from AWS client initialization Overflow when deserializing relational database objects Custom manual retries of AWS SDK calls Insufficient number of PBEKeySpec iterations URL redirection to untrusted site Use of externally-controlled input to select classes or code Missing null check for cache response metadata Inefficient usage of Transaction library from AWS Labs Insecure connection using unencrypted protocol Missing encryption of sensitive data in storage Inefficient additional authenticated data (AAD) authenticity Ignored output of DynamoDBMapper operations Use of a deprecated method Error-prone AWS IAM policy creation Use of externally-controlled input to build connection string Inefficient Amazon S3 manual pagination Null pointer dereference Cross-site scripting Unauthenticated LDAP requests Mutually exclusive call Use of inefficient APIs Low maintainability with old Android features AWS Lambda client not reused Atomicity violation Missing check on the result of createNewFile Missing handling of specifically-thrown exceptions Sensitive data stored unencrypted due to partial encryption Weak obfuscation of web request Missing statement to record cause of InvocationTargetException Misconfigured Concurrency Inefficient polling of AWS resource Clear text credentials Unexpected re-assignment of synchronized objects Session fixation XPath injection Syntax error in file Catching and not re-throwing or logging exceptions Missing check when launching an Android activity with an implicit intent Client constructor deprecation AWS client not reused in a Lambda function Inefficient use of stream sorting Arithmetic overflow or underflow Simplifiable code Loose file permissions Long polling is not enabled in Amazon SQS Insecure temporary file or directory HTTP response splitting Manual pagination Incorrect string equality operator Input and output values become out of sync Inefficient chain of AWS API calls Server-side request forgery OS command injection Missing Authorization for address id Do not catch and throw exception Code clone Concurrency deadlock Not recommended aws credentials classes SQL injection Path traversal Missing check on method output Override of reserved variable names in a Lambda function Missing byte array length of JSON parser Usage of an API that is not recommended Missing pagination Hardcoded credentials Insecure JSON web token (JWT) parsing Not calling finalize causes skipped cleanup steps Unchecked S3 object metadata content length Untrusted data in security decision Permissive cors configuration rule Insecure cookie Resources used by an Amazon S3 TransferManager are not released Insecure cryptography Resource leak Missing timezone of SimpleDateFormat XML External Entity Bad parameters used with AWS API methods Missing position check before getting substring LDAP injection Low maintainability with low class cohesion Avoid reset exception in Amazon S3 Oversynchronization Insecure hashing Backward compatibility breaks with error message parsing Inefficient map entry iteration Missing S3 bucket owner condition AWS DynamoDB getItem output is not null checked Log injection Sensitive information leak Infinite loop Batch operations preferred over looping Synchronous publication of AWS Lambda metrics XML External Entity Document Builder Factory Improper use of classes that aren't thread-safe Incorrect null check before setting a value Object Input Stream Insecure Deserialization Weak pseudorandom number generation Insecure CORS policy Insufficient use of name in Amazon SQS queue Missing check on the value returned by ResultSet.next Insecure TLS version Missing handling of file deletion result Amazon SQS message visibility changed without a status check State machine execution ARN is not logged Client-side KMS reencryption Unsanitized input is run as code Use Stream::anyMatch instead of Stream::findFirst or Stream::findAny Use an enum to specify an AWS Region Batch request with unchecked failures Improperly formatted string arguments

Unchecked S3 object metadata content length High

Uploading an object of type stream to Amazon S3 without setting the content length of the object will cause the entire contents of the input stream to be buffered locally in memory so that the content length can be calculated. This might result in negative performance problems.

Detector ID

java/s3-object-metadata-content-length-check@v1.0

Category

Common Weakness Enumeration (CWE)

Tags

# amazon-s3 # availability # aws-java-sdk # efficiency # security-context

Noncompliant example

1public void s3PutOjectFromStreamNoncompliant(AmazonS3 s3Client, File inputFile) throws FileNotFoundException {
2    String s3Bucket = "sample-bucket";
3    FileInputStream inputStream = null;
4    try {
5        inputStream = new FileInputStream(inputFile);
6        ObjectMetadata metadata = new ObjectMetadata();
7        // Noncompliant: puts object from stream without specifying the content length of the stream.
8        s3Client.putObject(s3Bucket, inputFile.getName(), inputStream, metadata);
9    } finally {
10        IOUtils.closeQuietly(inputStream, null);
11    }
12}

Compliant example

1public void s3PutOjectFromStreamCompliant(AmazonS3 s3Client, File inputFile) throws FileNotFoundException {
2    String s3Bucket = "sample-bucket";
3    FileInputStream inputStream = null;
4    try {
5        inputStream = new FileInputStream(inputFile);
6        ObjectMetadata metadata = new ObjectMetadata();
7        // Compliant: specifies the content length of the stream.
8        metadata.setContentLength(inputFile.length());
9        s3Client.putObject(s3Bucket, inputFile.getName(), inputStream, metadata);
10    } finally {
11        IOUtils.closeQuietly(inputStream, null);
12    }
13}